-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify example config #5
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5d0ddff
to
76ad09e
Compare
407bb82
to
26812d2
Compare
a7ee4f8
to
2b5517d
Compare
@@ -0,0 +1 @@ | |||
../../aws |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the base PR I actually switched to using GitHub paths with a branch, I actually forgot to point it back to main before landing:
github.com/xmtp/xmtpd-infrastructure//terraform/aws/xmtp-validation-service?ref=rich-tf-validation-svc
I wonder if that would be easier to work off of
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the right place to leave the repo. It gets a little weird when you're trying to run terraform validate
and you have any changes in the dependent modules.
You could push and then point at your current branch, but then you have to point back to main at some point...at which point the linter will fail. Almost need to break the PR into two pieces, one to update the module and one to update the dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll point it to main
in the next PR, when main
has stuff in the right place
76ad09e
to
e3b36f3
Compare
2b5517d
to
8de0840
Compare
8de0840
to
b4fa2c0
Compare
tl;dr
TODO
Testing
I've tested this with
terraform validate
but haven't deployed it yet