Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify example config #5

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Simplify example config #5

merged 1 commit into from
Nov 27, 2024

Conversation

neekolas
Copy link
Contributor

@neekolas neekolas commented Nov 26, 2024

tl;dr

  • Simplifies the example to be a flat plan with no modules other than our public modules
  • Renames the example
  • Adds some outputs to existing modules
  • Adds tflint

TODO

  • Still need to set up the DB

Testing

I've tested this with terraform validate but haven't deployed it yet

Copy link
Contributor Author

neekolas commented Nov 26, 2024

This was referenced Nov 26, 2024
@neekolas neekolas marked this pull request as ready for review November 26, 2024 01:07
@neekolas neekolas force-pushed the 11-25-create_xmtpd_worker_service branch from 5d0ddff to 76ad09e Compare November 26, 2024 01:25
@neekolas neekolas force-pushed the 11-25-simplify_example_config branch from 407bb82 to 26812d2 Compare November 26, 2024 01:25
@neekolas neekolas force-pushed the 11-25-simplify_example_config branch 3 times, most recently from a7ee4f8 to 2b5517d Compare November 26, 2024 01:53
@@ -0,0 +1 @@
../../aws
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the base PR I actually switched to using GitHub paths with a branch, I actually forgot to point it back to main before landing:

github.com/xmtp/xmtpd-infrastructure//terraform/aws/xmtp-validation-service?ref=rich-tf-validation-svc

I wonder if that would be easier to work off of

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the right place to leave the repo. It gets a little weird when you're trying to run terraform validate and you have any changes in the dependent modules.

You could push and then point at your current branch, but then you have to point back to main at some point...at which point the linter will fail. Almost need to break the PR into two pieces, one to update the module and one to update the dependency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll point it to main in the next PR, when main has stuff in the right place

@neekolas neekolas force-pushed the 11-25-create_xmtpd_worker_service branch from 76ad09e to e3b36f3 Compare November 27, 2024 00:17
@neekolas neekolas force-pushed the 11-25-simplify_example_config branch from 2b5517d to 8de0840 Compare November 27, 2024 00:17
Copy link
Contributor Author

neekolas commented Nov 27, 2024

Merge activity

  • Nov 26, 4:22 PM PST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 26, 4:27 PM PST: Graphite rebased this pull request as part of a merge.
  • Nov 26, 4:28 PM PST: A user merged this pull request with Graphite.

@neekolas neekolas changed the base branch from 11-25-create_xmtpd_worker_service to graphite-base/5 November 27, 2024 00:23
@neekolas neekolas changed the base branch from graphite-base/5 to main November 27, 2024 00:25
@neekolas neekolas force-pushed the 11-25-simplify_example_config branch from 8de0840 to b4fa2c0 Compare November 27, 2024 00:26
@neekolas neekolas merged commit 80ea75b into main Nov 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants